Conversation
| // | ||
| // If the struct is empty, then this returns an empty string. The caller is | ||
| // responsible for creating a default file path if needed. | ||
| func (p filePath) New() string { |
Contributor
There was a problem hiding this comment.
Test: could we add a test case for this logic that shows, verifies it can match selective data processing patterns/requirements? (like the previous default, AWS Glue, etc)
Contributor
Author
There was a problem hiding this comment.
I'll add a test that covers some functionality. It's worth mentioning that it can't catch every variation of the struct due to the use of UUID and time.
shellcromancer
approved these changes
Apr 17, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
filesink to write data to local diskfileandhttpsink support to the force-sink flag in the dev appMotivation and Context
Motivation and context is described in #91. Here's the impact of this PR:
[year]/[month]/[day]/[uuid].gz, file format is JSON, file compression is Gzipfw(file wrapper), this provides support for additional custom file format and compressionThe
filesink was added to test the usefulness of abstracting settings into a reusable struct versus keeping it only for the AWS S3 sink. In my opinion it works fine, and can be reused for other cloud service providers in the future.How Has This Been Tested?
Locally integration tested all filePath config options using AWS S3 and local files.
Types of changes
Checklist: