Fix: clang-cl based Windows AArch64 builds#2727
Open
dragonmux wants to merge 2 commits intobriansmith:mainfrom
Open
Fix: clang-cl based Windows AArch64 builds#2727dragonmux wants to merge 2 commits intobriansmith:mainfrom
dragonmux wants to merge 2 commits intobriansmith:mainfrom
Conversation
The build restriction for Windows AArch64 are still in place for MSVC, as it's unknown what the state of this compiler is, however clang-cl builds just fine and produces working crate binaries. This allows Windows cross-builds from Linux to work again and produce viable binaries. The warnings produced highlight some unsafe buffer usage from the native code, however these are the only notable output.
…rything` to clang(-cl) C11 and C99 compat warnings just generate useless noise
MarijnS95
reviewed
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we aim too address the state of Clang-cl (cross-)builds for Windows AArch64. This involves special-casing clang-cl to take extra warnings options that aren't valid for MSVC, and special-casing the MSVC carve-out in
configure_cc()of the build.rs.Clang-cl builds do actually work and produce viable binaries with these tweaks, thus allowing cross-building from Linux for Windows to work once again, something we do for the build and release process for bmputil and particularly as we release AArch64 binaries but do not have AArch64 Windows machines.
There are warnings that are still highlighted by Clang-cl about unsafe buffer accesses, however we feel these are out of scope for getting builds to work at all to start with. As a result, the force warnings into errors logic needs the condition
&& target.os != WINDOWSadded to stop the warnings being fatal when building from a Git clone and so spuriously failing the build.