Revert "optimize constant_time_conditional_memxor for gcc".#2735
Open
briansmith wants to merge 1 commit intomainfrom
Open
Revert "optimize constant_time_conditional_memxor for gcc".#2735briansmith wants to merge 1 commit intomainfrom
briansmith wants to merge 1 commit intomainfrom
Conversation
This reverts commit 9b3ef1b. It seems like the casts in the loop violate strict aliasing rules. This may result in a performance regression when GCC is used instead of Clang, as this code path was added specifically for GCC to address this performance difference.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
+ Coverage 96.64% 96.68% +0.04%
==========================================
Files 199 199
Lines 20311 20301 -10
Branches 524 524
==========================================
Hits 19629 19629
+ Misses 568 558 -10
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems BoringSSL found some alternative fix: |
Owner
Author
|
I think that one isn't relevant to this, right? That is addressing a different issue in the same function; see PR #2734. |
|
Got it, thought it might be all related to the same underlying issue, and hence potentially a way to fix the issue without performance regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b3ef1b. It seems like the casts in the loop violate strict aliasing rules.
This may result in a performance regression when GCC is used instead of Clang, as this code path was added specifically for GCC.