Yf make revert sam robust to errant XQ and XB tags#2021
Merged
kockan merged 6 commits intobroadinstitute:masterfrom Jul 25, 2025
Merged
Yf make revert sam robust to errant XQ and XB tags#2021kockan merged 6 commits intobroadinstitute:masterfrom
kockan merged 6 commits intobroadinstitute:masterfrom
Conversation
- checks that both are present before attempting to revert hard-clips - obtains values in a try-catch block - emits (up to 100) warning for problematic values of XB and XQ (only if both are present) - test included
Contributor
Author
|
Thanks @kockan I'm no longer a maintainer, so someone else will have to do the honors... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2020 so that RevertSamFile doesn't choke on XB or XQ even if they are not strings.
Description
Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests