[bugfix] call parent method in eglot-initialization-options#505
Open
SohumB wants to merge 1 commit intobrotzeit:masterfrom
Open
[bugfix] call parent method in eglot-initialization-options#505SohumB wants to merge 1 commit intobrotzeit:masterfrom
SohumB wants to merge 1 commit intobrotzeit:masterfrom
Conversation
(eglot-initialization-options) is a cl-defgeneric overridable method with a default implementation, and our code was overriding it but not calling the default implementation. This means that any core eglot logic around initialization options was failing to run, which had a user-visible consequence that the initializationOptions behaviour described in https://joaotavora.github.io/eglot/#User_002dspecific-configuration was not happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(eglot-initialization-options)is acl-defgenericoverridable method with a default implementation, and rustic-mode was overriding it but not calling the default implementation.This means that any core eglot logic around initialization options was failing to run, which had a user-visible consequence that the
initializationOptionsbehaviour described in the eglot manual was not happening.