Adding an article to FAQ-LightningNetwork.md#450
Closed
bereska wants to merge 1 commit intobtcpayserver:masterfrom
Closed
Adding an article to FAQ-LightningNetwork.md#450bereska wants to merge 1 commit intobtcpayserver:masterfrom
bereska wants to merge 1 commit intobtcpayserver:masterfrom
Conversation
Contributor
|
Blocked by #270 |
pavlenex
reviewed
Feb 20, 2020
pavlenex
reviewed
Feb 20, 2020
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
So besides minor formatting suggestions this looks okay to me.
A few things besides those:
- What is .DS_Store you've added?
- Could you please add a link to FAQ readme, since that's our Table of Content
I'll leave others to review actual scripts once the PR in docker is reviewed.
bereska
force-pushed
the
lnd-channels-backup-offsite
branch
from
7103534 to
cf792e1
Compare
pavlenex
reviewed
Feb 21, 2020
Date: Thu Feb 20 22:36:10 2020 +0300 Committer: bereska <bereska@MacBook-Air-DG-4007.local> Changes to be committed: modified: FAQ/FAQ-LightningNetwork.md# Changes to be committed: modified: FAQ/FAQ-LightningNetwork.md modified: FAQ/readme.md
bereska
force-pushed
the
lnd-channels-backup-offsite
branch
from
cf792e1 to
97841f9
Compare
Contributor
|
Thanks for quick changes @bereska, LGTM! |
Author
|
@pavlenex, thank you! |
Contributor
|
Closing due to inactivity, if you're willing to work on this in the future, feel free to re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to back up LND channels offsite ### was added to FAQ-LightningNetwork.md