lnd-channels-backup-dependencies

[bereska]

#270

[bereska]

btcpayserver/btcpayserver-docker#270
Hope I didn't miss the point)

[NicolasDorier]

Sorry to take lot's of time to review it I was busy those last days, I should be more reactive from now:

1. The tooling should be installed in the Dockerfile, not the script file so you don't have to download everytimes you start the container.
2. The script should be an infinite loop saving the SCB somewhere everytimes the file change
3. You should use tini utility to start your script, this prevent the container from hanging when you shut it down.

[bereska]

@NicolasDorier , no problem, thanks for your response. It's my turn to be more reactive).
My PR has 3 scripts:
lnd-channels-backup-dependencies.sh
lnd-channels-remote-backup-on-change.sh
lnd-channels-backup-systemd.sh

when you say 'tooling' do you mean all these scripts to be put in Dockerfile?
the problem I see is that lnd-channels-remote-backup-on-change.sh requires user input of remote server credentials (username & ip/hostname) and/or storage cloud credentials (name and auth token)
could you please guide me in the right direction how this could be implemented? I suspect that new ENV variables have to be added
thank you

[NicolasDorier]

Right now, everytimes the container get started, this run

echo "Checking rsync and inotify..."
for pkgs in rsync inotify-tools; do
        if [ $(dpkg -s $pkgs 2>/dev/null | grep -c "ok installed") -eq 1 ]; then
                echo "$pkgs is already installed "
        else
                apt -yy install $pkgs
                echo "Successfully installed $pkgs "
        fi
done

Containers does not save anything so any restart, you'll install same package over and over.
That's what installing package must be done in the Dockerfile, not in the entrypoint.

[NicolasDorier]

Last, the entrypoint is not doing anything, except installing the dependencies and shutting down. (and deleting what it just installed as explained above)