Added DecodeNoLimitGeneric to bech32.go#2186
Merged
guggero merged 1 commit intobtcsuite:masterfrom May 24, 2024
Merged
Conversation
guggero
reviewed
May 10, 2024
MarcoEzekiel
force-pushed
the
DecodeNoLimitVersioned
branch
from
82ce50d to
ccf694c
Compare
guggero
reviewed
May 13, 2024
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Code looks good to me. Can you please squash the two commits and add the btcutil/bech32: prefix to the commit message?
This exposes publicly the ability to decode arbitrary-length bech32 strings and return the bech32 version that was used in the encoding. It provides the underlying functionality for both DecodeNoLimit and DecodeGeneric.
MarcoEzekiel
force-pushed
the
DecodeNoLimitVersioned
branch
from
ccf694c to
2492b01
Compare
Pull Request Test Coverage Report for Build 9021239611Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
❤️ Good job |
Contributor
Author
|
Any Chance this will be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fix for issue Public DecodeNoLimit(encoded) #2185