Merged
Conversation
Follow up to #4382.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
It seems like this is the last version that protobuf-go actually supports; it hasn't been regenerated with the new 34.0 types.
stefanvanburen
changed the title
emcfarlane
approved these changes
Mar 10, 2026
doriable
approved these changes
Mar 10, 2026
stefanvanburen
added a commit
to bufbuild/makego
that referenced
this pull request
Mar 24, 2026
In bufbuild/buf#4383 I failed to notice that protoc was a makego dep; pulling in the latest via `copyfrommakego` in bufbuild/buf#4410 is reverting this change. May as well bump to latest. Ref: https://github.com/protocolbuffers/protobuf/releases
stefanvanburen
added a commit
to bufbuild/makego
that referenced
this pull request
Mar 24, 2026
In bufbuild/buf#4383 I failed to notice that protoc was a makego dep; pulling in the latest via `copyfrommakego` in bufbuild/buf#4410 is reverting this change. May as well bump to latest. Ref: https://github.com/protocolbuffers/protobuf/releases
stefanvanburen
added a commit
that referenced
this pull request
Mar 24, 2026
This had fallen out of sync with makego mistakenly from #4383; bumped to latest version in bufbuild/makego#295 and now pulled in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4382. Bumps PROTOC_VERSION (and related bits) to 33.3, which is the latest version that protobuf-go supports.
Ref: https://github.com/protocolbuffers/protobuf-go/commits/master/