Skip to content

update: make improvements to containers#50

Merged
bugfest merged 8 commits intobugfest:masterfrom
codekow:update-containers
Apr 11, 2023
Merged

update: make improvements to containers#50
bugfest merged 8 commits intobugfest:masterfrom
codekow:update-containers

Conversation

@codekow
Copy link
Contributor

@codekow codekow commented Apr 11, 2023

  • run as user 1001
  • remove bind mounts for src (issues with building on various platforms)
  • /app as home
  • add group write (g+w)
  • use fqdn for FROM

@bugfest
Copy link
Owner

bugfest commented Apr 11, 2023

Thanks for your PR @codekow! FYI / we're working in additional optimizations at #49 - I'll check what's the best ordering for the merge

@lexfrei
Copy link
Contributor

lexfrei commented Apr 11, 2023

I suggest applying this after my PR because my PR is a little bit simpler and has already tested (by me)

@codekow codekow marked this pull request as draft April 11, 2023 17:59
@codekow
Copy link
Contributor Author

codekow commented Apr 11, 2023

Hopefully the PR isn't too much change. Mainly trying to move toward rootless and a consistent /app path. Thanks for the feedback. 👍

@codekow codekow marked this pull request as ready for review April 11, 2023 18:18
@bugfest bugfest merged commit 5e88648 into bugfest:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants