Conversation
ZeeJab
force-pushed
the
zeejab/typescript-phase-5
branch
from
6d7751e to
8e3fa7c
Compare
ZeeJab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is Phase 5 of migrating the mobiledoc-kit lib to typescript. The focus here was the Editor + enabling
noImplicitAny!!In a previous PR I had updated some dependencies, but I rolled some of those back in this one due to unnecessary additional complications they were introducing for this particular phase.
This marks the end of migrating all the implementation code into TS. The next phases will be focused on migrating tests.