Merged
Conversation
warning: deleting object of polymorphic class type 'JavaCPP__0003a_0003aCallback' which has non-virtual destructor might cause undefined behavior
The assumption being, that the tests intention is to compare the JavaCCP Thread ID, which is the part after ID. Callback from Thread[bytedeco#51,JavaCPP Thread ID 115907,5,main] Callback from Thread[bytedeco#52,JavaCPP Thread ID 115907,5,main] Callback from Thread[bytedeco#53,JavaCPP Thread ID 115907,5,main]
Member
|
Looks good, but what does Loader.getPlatform() return? Is it "freebsd-x86_64" or something else? |
Member
|
And could you also add a freebsd-x86_64.properties even if it's just a copy of generic.properties? |
Contributor
Author
|
Yes, Loader.getPlatform() returns "freebsd-x86_64". |
Contributor
Author
|
With the platform/pom.xml I just repeated the patterns in there without really knowing what I am doing. Just delete it if it is not needed. |
saudet
approved these changes
Feb 17, 2026
saudet
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this adds FreeBSD support.
All tests pass on my FreeBSD amd64 machine except ThreadTest.
ThreadTest prints:
Callback from Thread[#51,JavaCPP Thread ID 115907,5,main]
Callback from Thread[#52,JavaCPP Thread ID 115907,5,main]
Callback from Thread[#53,JavaCPP Thread ID 115907,5,main]
I have to guess the tests intention. I changed the test under the assumption that these threads should be considered equal, since they have the same Thread ID.
I submit this because I use https://github.com/datalevin/datalevin which uses https://github.com/datalevin/dtlvnative which uses JavaCPP. Both of their tests pass too when the latter is ported to this version of JavaCPP here datalevin/dtlvnative@master...markusalbertgraf:dtlvnative:FreeBSD.
Best regards