Update comment about UV texture coordinates#42
Merged
vincentfretin merged 1 commit intoc-frame:masterfrom Apr 3, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found your comment in the code very confusing. The comment "(they are swapped from THREE.js 'y' axis logic)" doesn't make sense to me, THREE.js y axis is positive up, so that's the same as the texture y coordinate s actually with (0,0) in the bottom left and (1,1) in the top right.
In your comment you talked about "y axis coordinates for left eye on horizontal split", I think you meant vertical split here, otherwise it doesn't make sense to me that you're talking about y axis values here. That may be the source of your confusion?
I also put back the two lines comments that were before #38 I found those useful.