refactor(context): simplify refresh handling#164
Open
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Open
refactor(context): simplify refresh handling#164alikhere wants to merge 1 commit intoc2siorg:mainfrom
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Conversation
Author
|
Hi @Shubh942 Could you please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
fetchDatafunction inDataContextwas doing nothing useful — it just flippedrefreshback to false inside a try/catch that could never actually throw. This created a pointlessuseEffect→useCallback→ state update cycle on every refresh toggle without fetching any data.Removed
fetchDataand theuseEffectthat called it. The context now just exposesrefreshandsetRefreshas plain state, and individual components own their own fetch behavior when the flag changes. Also dropped the unuseduseCallbackanduseEffectimports since nothing in the file needs them anymore.How to test
cd webapp && npm run test— all Vitest suites passcd webapp && npm run build— Vite builds successfullycd gdbui_server && python -m unittest discover -s . -p 'flask_test.py'— all backend tests pass
refreshstill updatecorrectly when debug commands are triggered
Related Issue
Fixes #163
Notes