Fix: Return correct HTTP status codes on errors and sanitize file paths in compile/upload endpoints#168
Open
Omdeepb69 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
…le/upload endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related security and correctness issues fixed in gdbui_server/main.py:
HTTP status codes on errors
All GDB command endpoints were returning HTTP 200 OK even when an exception
occurred and success: False was set in the response body. This makes it
impossible for clients to distinguish success from failure without parsing
the body. Fixed by returning 500 on exceptions.
Path traversal vulnerability in /compile and /upload_file
The name parameter from user input was used directly in file paths without
sanitization. A malicious input like "../../../etc/passwd" could write files
outside the intended output directory. Fixed by applying
werkzeug.utils.secure_filename() to all user-supplied filenames.
Output directory creation on startup
Added os.makedirs(OUTPUT_DIR, exist_ok=True) so the output/ directory is
created automatically. This fixes a crash on first run in fresh Docker
deployments where the directory does not exist yet.
These fixes directly address the CI/CD Integration and First Deployment
objectives from the GSoC 2026 project description.