fix: handle dtype coercion when editing cells (closes #231)#232
Open
vikask011 wants to merge 2 commits intoc2siorg:mainfrom
Open
fix: handle dtype coercion when editing cells (closes #231)#232vikask011 wants to merge 2 commits intoc2siorg:mainfrom
vikask011 wants to merge 2 commits intoc2siorg:mainfrom
Conversation
PR ReviewSquashYour PR has 2 commits. Please squash into a single commit. How to fixgit fetch origin
git rebase -i origin/main # mark all but first commit as "squash"
git push --force-with-leaseThis comment updates automatically on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves a bug where updating cell values in columns with predefined data types (
int,float,bool) results in a validation error. This occurred because values sent from the frontend are always strings, leading to incompatibility when directly assigning them to typed pandas columns.The fix introduces proper type conversion before updating the DataFrame, ensuring compatibility with the column’s dtype and preventing runtime errors.
Closes #231
Type of Change
Bug fix
Testing
Tested with datasets containing integer, float, and boolean columns.
Modified cell values through the UI and verified successful updates without backend errors.
Confirmed no regressions in existing functionality and ensured existing tests pass.
Checklist
Code follows the project's style guidelines
Self-review performed
No new warnings generated
Tests pass locally