fix(frontend): prevent invalid file uploads from triggering API calls#235
Open
sanchit955 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix(frontend): prevent invalid file uploads from triggering API calls#235sanchit955 wants to merge 1 commit intoc2siorg:mainfrom
sanchit955 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
f505da4 to
cb3371f
Compare
a01298b to
20a2259
Compare
Author
|
Hi maintainers, I’ve squashed the commits into a single commit and all checks are now passing. Would love your review 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent unnecessary API calls for invalid file uploads
Previously, selecting an unsupported or invalid file still triggered an API request to
/projects/upload, which resulted in a backend 400 error. This caused unnecessary network calls and a poor user experience.Changes
acceptattribute to file input for better UXSupported formats
.csv, .xlsx, .json, .parquet, .tsv
Impact