Fix delRow replay to use delete_row for RangeIndex consistency#237
Open
RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
Open
Fix delRow replay to use delete_row for RangeIndex consistency#237RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
Replay delRow through delete_row so index matches the live transform path. Apply ruff format to transformation tests. Made-with: Cursor
RachanaB5
force-pushed
the
fix/delrow-replay-uses-delete-row
branch
from
adfbd80 to
46a293a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236
Changes Made
app/services/transformation_service.py
delete_row(df, index) to match live behavior
Tests
All 4 existing tests pass ✅