Unify transform persistence for filter, sort, advQuery, and pivot#239
Open
RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
Open
Unify transform persistence for filter, sort, advQuery, and pivot#239RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
RachanaB5 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
…able - Backend: save and log filter, sort, advQueryFilter, pivotTables; replay in apply_logged_transformation - Frontend: wire Filter/Sort/AdvQuery/Pivot to onTransform; sync ProjectContext from DataScreen - fix: call onTransform/onClose in adv query and pivot forms (ESLint) Made-with: Cursor
b700635 to
2aa0cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #238
Summary
This PR standardizes the behavior of view-level transformations (
filter,sort,advQueryFilter,pivotTables) by making them persisted operations.Previously, these operations could return updated data without saving to the working CSV, leading to inconsistencies between:
GET /projects/get/{project_id})Changes
Backend
should_save = Truefor:apply_logged_transformationFrontend
onTransformafter API successProjectContextviaupdateData(important for pivot/dtypes)Tests
TestApplyLoggedViewTransforms)Result
GET) returns consistent dataNotes
transformation_input.dict()(can migrate tomodel_dump()later)How to test
Happy to split this into smaller PRs if preferred.