COM: last_modified not updating after transforms#245
Open
meghanagottapu wants to merge 3 commits intoc2siorg:mainfrom
Open
COM: last_modified not updating after transforms#245meghanagottapu wants to merge 3 commits intoc2siorg:mainfrom
meghanagottapu wants to merge 3 commits intoc2siorg:mainfrom
Conversation
PR ReviewSquashYour PR has 3 commits. Please squash into a single commit. How to fixgit fetch origin
git rebase -i origin/main # mark all but first commit as "squash"
git push --force-with-leaseThis comment updates automatically on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Project model has a last_modified column used to order the homescreen 'Recently Modified' list. Before this fix, last_modified was only stamped at project creation - it was never updated when a transformation was applied. This meant the homescreen always ordered projects by upload time, not by actual activity. Projects you were actively working on would sink below projects that were uploaded more recently but untouched.
Root Cause
The root cause was in project_service.log_transformation(): it wrote a ProjectChangeLog row and committed, but never touched the parent Project row. The fix adds four lines that fetch the parent Project and stamp last_modified = datetime.now(timezone.utc) in the same commit.
Fixes #244
Type of Change
How Has This Been Tested?
A new test file has been added: tests/test_last_modified.py - 6 tests at the service layer
Describe the tests you ran to verify your changes.
Checklist