fix: use correct param keys for add and delete column ops#258
Open
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: use correct param keys for add and delete column ops#258alikhere wants to merge 1 commit intoc2siorg:mainfrom
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Conversation
56ed55e to
efcecf1
Compare
Author
|
Hi @ivantha , Could you please review the PR whenever you get time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The right-click context menu for adding and deleting columns was silently broken for every user. Both
handleAddColumnandhandleDeleteColumninTable.jsxwere sending the request body with the keycol_params, but the backendTransformationInputschema expectsadd_col_paramsanddel_col_paramsrespectively. FastAPI would set those fields toNoneand the handler would throw a 400. This fixes the fix is two key renames:col_params→add_col_paramsinhandleAddColumnandcol_params→del_col_paramsinhandleDeleteColumn.Type of Change
How Has This Been Tested?
Ran
npm run test(48 frontend tests pass),npm run lint, andnpm run build— all clean. Ranuv run pyteston the backend — 92 tests pass. The one pre-existing failure (test_add_column_without_name_returns_422) was confirmed to exist on main before this branch and is tracked separately as issue #4. Manually verified that right-clicking a column header and choosing "Add Column" and "Delete Column" now succeeds instead of showing the error toast.Fixes #257
Screenshots (if applicable)
After fix:
dataloom2.mp4
Checklist