-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
systemd.listen placeholder and bind interfaces subdirective #7340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+802
−499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5f56ec.
Contributor
Author
|
going to cherrypick and reopen now that tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
No AI was used.
Implements #7243 as a placeholder,
bind sd/name/0->bind fd/{systemd.listen.name:0}. A custom network was only beneficial to implement support with a plugin, the actual behavior needed was just a fancy{env.}that substitutes the index of a value from an array in the environment. Using one avoids complicating the config syntax and parsing, and sets us up for more systemd placeholders like systemd-creds.