-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
bind to_device subdirective #7343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MayCXC
wants to merge
17
commits into
caddyserver:master
Choose a base branch
from
MayCXC:bind-interfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+844
−510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
converted to draft because it shares some diffs with #7342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
No AI was used.
Adds a
to_devicesubdirective forbindto implement #7256 without changing how addresses are parsed otherwise:in the example above, the site is bound to at least three addresses. This way the
tcp6/udp6/andip6:networks can be used instead of a new version mode syntax, and the port is read from the site block again instead of the directive arguments.Only one address is bound per prefix for interfaces assigned a cidr. This is preferable to composing or selecting multiple addresses to emulate a bind to device syscall; a socket manager can do that natively without the overhead of opening 2^n listeners at once, or the unreliability of trying to open the first one available iteratively. e.g. for linux, the user could apply #7342 with systemd.socket and BindToDevice/FreeBind.
Tests are todo, ideally we will mock the value of
net.InterfaceByNameand parse a caddyfile.