execute module replacement in a single command#178
Merged
mohammed90 merged 2 commits intocaddyserver:masterfrom Apr 6, 2024
Merged
execute module replacement in a single command#178mohammed90 merged 2 commits intocaddyserver:masterfrom
mohammed90 merged 2 commits intocaddyserver:masterfrom
Conversation
Member
|
Seems sensible. This only affects |
Member
Author
|
Didn't test. But isn't the whole point of I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing http3 graceful shutdown, I found out I can't build caddy with local plugin by
xcaddy build http3-graceful --with github.com/quic-go/quic-go=github.com/WeidiDeng/quic-go@graceful-close --with plugin=path, I have to manually switchwithpositions.Turns out the multiple replaces can be executed at once, so the order no longer matters.