Skip to content

bugfix- #221, xcaddy skips minor updates of lexical submodules#238

Merged
mholt merged 4 commits intocaddyserver:masterfrom
Jesssullivan:221-fetch-uncached-modules
May 5, 2025
Merged

bugfix- #221, xcaddy skips minor updates of lexical submodules#238
mholt merged 4 commits intocaddyserver:masterfrom
Jesssullivan:221-fetch-uncached-modules

Conversation

@Jesssullivan
Copy link
Contributor

Resolves #221

Current behavior:

  • xcaddy skips minor updates of lexical submodules

Intended behavior:

  • xcaddy will ingest logically tagged and / or latest modules when semantically updated or a new release is available to @latest.

To demo the bug:

git clone https://github.com/infogulch/xtemplate && cd xtemplate
xcaddy build --with github.com/infogulch/xtemplate-caddy@v0.2.2 --with github.com/infogulch/xtemplate=.
go get github.com/infogulch/xtemplate-caddy@v0.2.2

# this should fail, but does not:
xcaddy build --with github.com/infogulch/xtemplate-caddy@v0.2.5 --with github.com/infogulch/xtemplate=.

# note, this behavior cannot be replicated with major semantic changes, eg, v0 --> v1.

To demo the fix:

# get extant release
git clone https://github.com/jesssullivan/xcaddy && cd xcaddy
git checkout 221-fetch-uncached-modules
cd 221-xtemplate-caddy 
go mod tidy && go build -o xcaddy ./cmd/xcaddy

cd ../xtemplate
./xcaddy/xcaddy build --with github.com/infogulch/xtemplate-caddy@v0.2.5 --with github.com/infogulch/xtemplate=. # <-- successfully fails ^w^

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We can give this a try.

@mholt
Copy link
Member

mholt commented May 1, 2025

Although, the lint errors should probably be fixed first

@mholt mholt merged commit 471f043 into caddyserver:master May 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xcaddy does not download newly published module versions, even when specified

4 participants