Skip to content

Show Active Cluster Selection Policy on Workflow Summary page#1006

Merged
adhityamamallan merged 6 commits intocadence-workflow:masterfrom
adhityamamallan:active-cluster-policy-summary
Sep 3, 2025
Merged

Show Active Cluster Selection Policy on Workflow Summary page#1006
adhityamamallan merged 6 commits intocadence-workflow:masterfrom
adhityamamallan:active-cluster-policy-summary

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Sep 1, 2025

Summary

  • Add Active Cluster Selection Strategy, and strategy-specific fields to Workflow Summary page
  • Fix type issues with formatted start event, by creating a new fixture using type casting

Test plan

Added unit tests + ran locally.

Regular local domain workflow

Screenshot 2025-09-01 at 5 44 28 PM

Active-active domain workflow

Screenshot 2025-09-01 at 5 38 21 PM Screenshot 2025-09-01 at 5 45 02 PM

@adhityamamallan adhityamamallan force-pushed the active-cluster-policy-summary branch from 1c4ab22 to d6b4130 Compare September 2, 2025 08:38
@adhityamamallan adhityamamallan marked this pull request as ready for review September 2, 2025 08:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds active cluster selection policy information to the Workflow Summary page, displaying the strategy type and relevant strategy-specific fields based on the selected strategy.

  • Add display of active cluster selection strategy and related fields in workflow summary
  • Create helper function to extract policy from workflow details or first event
  • Fix typing issues by creating proper fixture for formatted start event with type casting

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
workflow-summary-details.types.ts Export type and refactor field arguments structure for reusability
workflow-summary-details.constants.ts Add strategy label mapping for display names
get-active-cluster-selection-policy.ts Helper function to extract policy from workflow details or first event
get-active-cluster-selection-policy.test.ts Unit tests for policy extraction helper
workflow-summary-details.test.tsx Update test to use new typed fixture instead of inline casting
workflow-summary-details.config.ts Add four new fields for cluster strategy information
formatted-first-history-event.ts Create properly typed fixture to resolve type casting issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Assem-Uber Assem-Uber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to include screenshots for Entity Type & Entity Key too,

@adhityamamallan
Copy link
Member Author

It would be better to include screenshots for Entity Type & Entity Key too,

I would have liked to, but the feature has not been implemented in the backend yet 😅

@adhityamamallan adhityamamallan merged commit a8cb2ec into cadence-workflow:master Sep 3, 2025
1 check passed
@Assem-Uber
Copy link
Contributor

Assem-Uber commented Sep 3, 2025

I see, it is not clear from the summary that this is not available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants