Show Active Cluster Selection Policy on Workflow Summary page#1006
Conversation
1c4ab22 to
d6b4130
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds active cluster selection policy information to the Workflow Summary page, displaying the strategy type and relevant strategy-specific fields based on the selected strategy.
- Add display of active cluster selection strategy and related fields in workflow summary
- Create helper function to extract policy from workflow details or first event
- Fix typing issues by creating proper fixture for formatted start event with type casting
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-summary-details.types.ts | Export type and refactor field arguments structure for reusability |
| workflow-summary-details.constants.ts | Add strategy label mapping for display names |
| get-active-cluster-selection-policy.ts | Helper function to extract policy from workflow details or first event |
| get-active-cluster-selection-policy.test.ts | Unit tests for policy extraction helper |
| workflow-summary-details.test.tsx | Update test to use new typed fixture instead of inline casting |
| workflow-summary-details.config.ts | Add four new fields for cluster strategy information |
| formatted-first-history-event.ts | Create properly typed fixture to resolve type casting issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Assem-Uber
left a comment
There was a problem hiding this comment.
It would be better to include screenshots for Entity Type & Entity Key too,
I would have liked to, but the feature has not been implemented in the backend yet 😅 |
|
I see, it is not clear from the summary that this is not available yet. |
Summary
Test plan
Added unit tests + ran locally.
Regular local domain workflow
Active-active domain workflow