Skip to content

Multi json input#1015

Merged
Assem-Uber merged 5 commits intocadence-workflow:masterfrom
Assem-Uber:feature/15219/multi-json-input
Sep 12, 2025
Merged

Multi json input#1015
Assem-Uber merged 5 commits intocadence-workflow:masterfrom
Assem-Uber:feature/15219/multi-json-input

Conversation

@Assem-Uber
Copy link
Contributor

@Assem-Uber Assem-Uber commented Sep 5, 2025

Summary
Create an input that allows adding multiple JSON, required for adding workflow input arguments.

Requirements

  • Allow adding more than one input
  • Disables the add button when not all fields are filled
  • Delete button removes the input, except if there is one input it clears it.
  • Delete button is disabled when the only existing input is empty

Screenshots
Screenshot 2025-09-05 at 19 34 24
Screenshot 2025-09-09 at 15 54 11
Screenshot 2025-09-09 at 15 54 20
Screenshot 2025-09-09 at 15 54 42

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new MultiJsonInput component that allows users to add and manage multiple JSON inputs dynamically, designed for workflow input arguments. The component provides add/remove functionality with intelligent button states based on input content.

Key changes:

  • Creates a reusable multi-input component with dynamic add/remove capabilities
  • Implements smart button state management (add disabled when fields empty, delete disabled for single empty input)
  • Provides comprehensive error handling for both global and per-input validation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/components/multi-json-input/multi-json-input.types.tsx Defines TypeScript interface for component props including value array and error handling
src/components/multi-json-input/multi-json-input.tsx Main component implementation with input management logic and UI rendering
src/components/multi-json-input/multi-json-input.styles.ts Styletron-based CSS styling for component layout and visual design
src/components/multi-json-input/tests/multi-json-input.test.tsx Comprehensive test suite covering component behavior and user interactions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Assem-Uber Assem-Uber merged commit c839930 into cadence-workflow:master Sep 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants