Support additional fields to start api#1026
Merged
Assem-Uber merged 4 commits intocadence-workflow:masterfrom Sep 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the start workflow API to support additional workflow configuration fields including Header, Memo, SearchAttributes, Retry Policy, and WorkflowIdReusePolicy. It also improves error handling by differentiating between duplicate workflow errors and other errors in logging.
- Add support for 5 new workflow configuration fields in the API schema and request handling
- Implement conditional logging that uses
infolevel for duplicate workflow errors instead oferror - Add comprehensive test coverage for all new fields with proper data transformation verification
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/grpc/grpc-error.ts | Maps ALREADY_EXISTS gRPC status to HTTP 409 for duplicate workflow handling |
| src/route-handlers/start-workflow/start-workflow.ts | Processes new workflow fields and implements conditional error logging |
| src/route-handlers/start-workflow/start-workflow.constants.ts | Defines valid WorkflowIdReusePolicy enum values |
| src/route-handlers/start-workflow/schemas/start-workflow-request-body-schema.ts | Adds validation schemas for new workflow configuration fields |
| src/route-handlers/start-workflow/tests/start-workflow.node.ts | Adds comprehensive test coverage for all new fields with proper assertions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/route-handlers/start-workflow/schemas/start-workflow-request-body-schema.ts
Outdated
Show resolved
Hide resolved
src/route-handlers/start-workflow/schemas/start-workflow-request-body-schema.ts
Show resolved
Hide resolved
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
adhityamamallan
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add following fields to start API:
Changes
info&errorbased on the error typeTest
Locally through Form