Add an improved Multi Select Filter component to history page filters#1032
Merged
adhityamamallan merged 5 commits intocadence-workflow:masterfrom Sep 18, 2025
Merged
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an improved MultiSelectFilter component with checkboxes and "Select All" functionality to replace the existing multi-select dropdowns on the workflow history page filters.
- Creates a new MultiSelectFilter component with overridden dropdown menu containing checkboxes and Select All option
- Replaces existing Select components in Type and Status filters with the new MultiSelectFilter
- Improves filter layout styling for consistent spacing across non-minified filters
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-history-filters-type.tsx | Replaces BaseUI Select with new MultiSelectFilter component |
| workflow-history-filters-status.tsx | Replaces BaseUI Select with new MultiSelectFilter component |
| workflow-history-filters-type.styles.ts | Removes unused styling file |
| workflow-history-filters-status.styles.ts | Removes unused styling file |
| page-filters.styles.ts | Removes unused overrides and styling code |
| page-filters-fields.styles.ts | Improves filter layout styling for consistent spacing |
| multi-select-filter/* | Adds new MultiSelectFilter component with custom dropdown menu |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/multi-select-filter/multi-select-menu/multi-select-menu.tsx
Show resolved
Hide resolved
...w-history/workflow-history-filters-status/__tests__/workflow-history-filters-status.test.tsx
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page-filters.styles.tsTest plan
Added unit tests + ran locally.
Filter in action
Unmodified filter
Modified filter
Empty filter