Skip to content

Add an improved Multi Select Filter component to history page filters#1032

Merged
adhityamamallan merged 5 commits intocadence-workflow:masterfrom
adhityamamallan:filter-v2
Sep 18, 2025
Merged

Add an improved Multi Select Filter component to history page filters#1032
adhityamamallan merged 5 commits intocadence-workflow:masterfrom
adhityamamallan:filter-v2

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Sep 16, 2025

Summary

  • Create new MultiSelectFilter component with overridden selection menu, with checkboxes and Select All
  • Use component in History Page filters (type & status)
  • (misc) Fix styling in Page Filters so that non-minified filters share space evenly regardless of content
  • (misc) Delete unused styles from page-filters.styles.ts

Test plan

Added unit tests + ran locally.

Filter in action

Screenshot 2025-09-16 at 13 03 51

Unmodified filter

Screenshot 2025-09-16 at 13 01 47

Modified filter

Screenshot 2025-09-16 at 13 01 51

Empty filter

Screenshot 2025-09-16 at 13 29 22

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an improved MultiSelectFilter component with checkboxes and "Select All" functionality to replace the existing multi-select dropdowns on the workflow history page filters.

  • Creates a new MultiSelectFilter component with overridden dropdown menu containing checkboxes and Select All option
  • Replaces existing Select components in Type and Status filters with the new MultiSelectFilter
  • Improves filter layout styling for consistent spacing across non-minified filters

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workflow-history-filters-type.tsx Replaces BaseUI Select with new MultiSelectFilter component
workflow-history-filters-status.tsx Replaces BaseUI Select with new MultiSelectFilter component
workflow-history-filters-type.styles.ts Removes unused styling file
workflow-history-filters-status.styles.ts Removes unused styling file
page-filters.styles.ts Removes unused overrides and styling code
page-filters-fields.styles.ts Improves filter layout styling for consistent spacing
multi-select-filter/* Adds new MultiSelectFilter component with custom dropdown menu

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 7ae9624 into cadence-workflow:master Sep 18, 2025
4 checks passed
adhityamamallan added a commit that referenced this pull request Mar 4, 2026
…1200)

Use improved Multi Select Filter (added in #1032) in Domain Workflows list pages (regular and archival)

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants