Skip to content

Add lastFailureDetails and lastFailureReason to pending event summary#1033

Merged
adhityamamallan merged 3 commits intocadence-workflow:masterfrom
adhityamamallan:pending-failure-details
Sep 18, 2025
Merged

Add lastFailureDetails and lastFailureReason to pending event summary#1033
adhityamamallan merged 3 commits intocadence-workflow:masterfrom
adhityamamallan:pending-failure-details

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Sep 17, 2025

Summary

  • Show lastFailureDetails and lastFailureReason on pending event summary, for a pending event that's retrying
  • Render them as negative fields
  • Parse lastFailureDetails as JSON
  • Fix the unit tests to use exact event metadata index instead of trying to find event metadata based on the label

Test plan

Updated unit tests + ran locally.

Screenshot 2025-09-17 at 11 30 16 Screenshot 2025-09-17 at 14 19 22 Screenshot 2025-09-17 at 14 19 27

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the pending event summary display by adding failure information to help users understand retry attempts. It shows lastFailureReason and lastFailureDetails as negative fields for pending activities that are retrying, and updates the configuration to properly render these fields as JSON.

  • Add lastFailureReason and lastFailureDetails to pending activity event configurations
  • Update regex patterns to include lastFailureDetails for proper JSON rendering
  • Refactor test assertions to use direct array indexing instead of searching by metadata properties

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
get-activity-group-from-events.ts Add failure fields to pending activity configurations for negative and summary fields
get-activity-group-from-events.test.ts Update test assertions to use exact array indices instead of metadata searches
workflow-history-event-summary-field-parsers.config.ts Add lastFailureDetails to JSON field parser regex pattern
workflow-history-event-details.config.ts Add lastFailureDetails to JSON details renderer regex pattern

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 559d9cb into cadence-workflow:master Sep 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants