Add lastFailureDetails and lastFailureReason to pending event summary#1033
Merged
adhityamamallan merged 3 commits intocadence-workflow:masterfrom Sep 18, 2025
Merged
Conversation
c408013 to
9db9a09
Compare
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
9db9a09 to
c5cde2c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the pending event summary display by adding failure information to help users understand retry attempts. It shows lastFailureReason and lastFailureDetails as negative fields for pending activities that are retrying, and updates the configuration to properly render these fields as JSON.
- Add
lastFailureReasonandlastFailureDetailsto pending activity event configurations - Update regex patterns to include
lastFailureDetailsfor proper JSON rendering - Refactor test assertions to use direct array indexing instead of searching by metadata properties
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| get-activity-group-from-events.ts | Add failure fields to pending activity configurations for negative and summary fields |
| get-activity-group-from-events.test.ts | Update test assertions to use exact array indices instead of metadata searches |
| workflow-history-event-summary-field-parsers.config.ts | Add lastFailureDetails to JSON field parser regex pattern |
| workflow-history-event-details.config.ts | Add lastFailureDetails to JSON details renderer regex pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ews/workflow-history/helpers/get-history-group-from-events/get-activity-group-from-events.ts
Show resolved
Hide resolved
Assem-Uber
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Updated unit tests + ran locally.