fix: propagate user headers between internal api requests#1049
Merged
Assem-Uber merged 7 commits intocadence-workflow:masterfrom Oct 23, 2025
Conversation
adhityamamallan
approved these changes
Oct 23, 2025
Assem-Uber
deleted the
bugfix/15162/propagat-user-headers-from-server-rendering
branch
Assem-Uber
added a commit
to Assem-Uber/cadence-web
that referenced
this pull request
Oct 24, 2025
…rkflow#1049) * propagate user headers from server renders * fix tests * dynamically import headers * log propagated header keys * add test cases * import headers inline
Assem-Uber
added a commit
that referenced
this pull request
Oct 27, 2025
* Search attribute component Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Fix type check Signed-off-by: Assem Hafez <assem.hafez@uber.com> * revert errors to have key and value Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Address the nits * change button label * Create hook for fetching search attributes Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Refactor error message helpers * feat: Create hook for fetching search attributes (#1046) * Create hook for fetching search attributes Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use stringifyUrl Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: propagate user headers between internal api requests (#1049) * propagate user headers from server renders * fix tests * dynamically import headers * log propagated header keys * add test cases * import headers inline * Add import/named to lint rules (#1050) *Add import/named rule to .eslintrc to enable detecting import issues * Use deep imports for Lodash * Fix other misc lint issues (unused imports/variables) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * remove type Signed-off-by: Assem Hafez <assem.hafez@uber.com> * lint fixes Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
added a commit
that referenced
this pull request
Oct 29, 2025
* Search attribute component Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Fix type check Signed-off-by: Assem Hafez <assem.hafez@uber.com> * revert errors to have key and value Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Address the nits * change button label * Create hook for fetching search attributes Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Refactor error message helpers * feat: Create hook for fetching search attributes (#1046) * Create hook for fetching search attributes Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use stringifyUrl Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: propagate user headers between internal api requests (#1049) * propagate user headers from server renders * fix tests * dynamically import headers * log propagated header keys * add test cases * import headers inline * Add import/named to lint rules (#1050) *Add import/named rule to .eslintrc to enable detecting import issues * Use deep imports for Lodash * Fix other misc lint issues (unused imports/variables) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * remove type Signed-off-by: Assem Hafez <assem.hafez@uber.com> * lint fixes Signed-off-by: Assem Hafez <assem.hafez@uber.com> * align multi json add button design with search attributes * add parsing for double Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Add search attributes to start form Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move label to form Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change test case for search attributes validation Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change test case for search attributes validation Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server rendered pages calles our APIs to render the initial version of the page. User tokens are not propagated to the API calls so auth may not work as expected.
Testing
Made sure headers are propagated to APIs