refactor: Move history header to separate component#1057
Merged
Assem-Uber merged 7 commits intocadence-workflow:masterfrom Oct 31, 2025
Merged
Conversation
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the workflow history header by extracting it into a separate component (WorkflowHistoryHeader), preparing for future sticky/non-sticky behavior. It also standardizes filter spacing across different pages by introducing consistent container wrappers.
Key Changes:
- Extracted workflow history header logic into a dedicated
WorkflowHistoryHeadercomponent - Standardized filter field spacing by wrapping them in containers with consistent top margins
- Added comprehensive test coverage for the new header component
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/views/workflow-history/workflow-history.tsx |
Replaced inline header with WorkflowHistoryHeader component and simplified state management |
src/views/workflow-history/workflow-history.styles.ts |
Removed header-related styles (moved to new component) and adjusted content section margin |
src/views/workflow-history/workflow-history-header/workflow-history-header.types.ts |
Defined prop types for the new header component |
src/views/workflow-history/workflow-history-header/workflow-history-header.tsx |
New component containing extracted header logic with timeline chart and filter toggles |
src/views/workflow-history/workflow-history-header/workflow-history-header.styles.ts |
Styles for the new header component including container, header, and actions sections |
src/views/workflow-history/workflow-history-header/__tests__/workflow-history-header.test.tsx |
Comprehensive test suite for the new header component |
src/views/workflow-history/__tests__/workflow-history.test.tsx |
Updated tests to use mocked header component |
src/views/domains-page/domains-page-filters/domains-page.filters.styles.ts |
Added bottom margin styling for domains page filters |
src/views/domains-page/domains-page-filters/domains-page-filters.tsx |
Wrapped filters in styled container for consistent spacing |
src/views/domain-workflows-basic/domain-workflows-basic-filters/domain-workflows-basic-filters.tsx |
Added FiltersContainer wrapper for consistent spacing |
src/views/domain-workflows-basic/domain-workflows-basic-filters/domain-workflows-basic-filters.styles.ts |
Added FiltersContainer style definition |
src/components/page-filters/page-filters.tsx |
Wrapped filter fields in container for consistent spacing |
src/components/page-filters/page-filters.styles.ts |
Removed bottom margin from search container, added FiltersContainer style |
src/components/page-filters/page-filters-fields/page-filters-fields.styles.ts |
Removed bottom margin (handled by parent container) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+49
| BaseButton: { | ||
| style: ({ $theme }: { $theme: Theme }) => ({ | ||
| paddingLeft: $theme.sizing.scale500, | ||
| paddingRight: $theme.sizing.scale500, | ||
| }), | ||
| }, |
There was a problem hiding this comment.
The override key should be 'Root' instead of 'BaseButton' for Button component overrides. BaseUI Button components use 'Root' as the primary override key.
adhityamamallan
approved these changes
Oct 29, 2025
src/views/workflow-history/workflow-history-header/workflow-history-header.types.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving workflow history header component to its own component in preparation for adding sticky vs none sticky behaviour.
Changes
Screenshots
