feat: Sticky workflow header#1058
Merged
Assem-Uber merged 9 commits intocadence-workflow:masterfrom Nov 4, 2025
Merged
Conversation
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
| const sentinel = sentinelRef.current; | ||
| if (!sentinel) return; | ||
|
|
||
| const observer = new IntersectionObserver( |
Member
There was a problem hiding this comment.
Don't we have a React hook for the intersection observer, with mocks? We can use that instead
Contributor
Author
There was a problem hiding this comment.
Yes, i was trying to recall what it was. But now i recall i just saw it in history page.
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
gazi-yestemirova
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support prop for workflow header to allow sticky behavior. Sticky header is disabled by default
Screen recording
Screen.Recording.2025-10-28.at.08.44.17.mov