feat: Filters for Failover History Table by adhityamamallan · Pull Request #1079 · cadence-workflow/cadence-web

adhityamamallan · 2025-11-14T13:41:24Z

Summary

Add filters for Failover History table, but only for active-active domains
Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes
Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names
Remove (now) unused styles file from DomainPageFailovers

Test plan

Unit tests + ran locally.

Unset

Suggestions

City ID

Primary cluster failovers only (cluster attribute value is greyed out)

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Copilot

Pull Request Overview

This PR adds filtering capabilities to the Failover History table for active-active domains, allowing users to filter by cluster attribute scope and value. The filters have dependent behavior where the value filter options are determined by the selected scope.

Key changes:

Introduced a new DomainPageFailoversFilters component with two dependent combobox filters and a reset button
Integrated filters into the main failovers page, conditionally rendered only for active-active domains
Removed unused styles file from the failovers component

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/views/domain-page/domain-page-failovers/domain-page-failovers.tsx`	Integrated the new filters component with conditional rendering for active-active domains and updated query params handling
`src/views/domain-page/domain-page-failovers/domain-page-failovers.styles.ts`	Removed unused styles file that contained only padding styles
`src/views/domain-page/domain-page-failovers/__tests__/domain-page-failovers.test.tsx`	Added mock for filters component and test case to verify filters render for active-active domains
`src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.tsx`	Created new filters component with scope and value comboboxes that have dependent behavior
`src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.styles.ts`	Added responsive styling for filter layout with mobile-first approach
`src/views/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx`	Comprehensive test suite covering all filter interactions and edge cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

macrotim · 2025-11-15T17:07:45Z

I'm wondering how to repro the failover data on my local?

...s/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Add filters for Failover History table, but only for active-active domains Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names Remove (now) unused styles file from DomainPageFailovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

* Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * init grouper hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * user grouper in history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * mock grouper throttle Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use fetcher test case Signed-off-by: Assem Hafez <assem.hafez@uber.com> * feat: Grouped events table header (#1059) * Grouped events header Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix comment typo Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add space for reset button Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move grouped table Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * Change Id to ID Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * chore: Fixed docker URI for kafka image (#1066) Signed-off-by: Tim Chan <tim.chan@uber.com> * chore: New feature flag for Cron List View (#1068) Signed-off-by: Tim Chan <tim.chan@uber.com> * use fetcher in workflow history * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use initial selected event Signed-off-by: Assem Hafez <assem.hafez@uber.com> * increase page size Signed-off-by: Assem Hafez <assem.hafez@uber.com> * optimize first page processing Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: History content negative z-index disallow clicks (#1069) * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/workflow-history.styles.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Use fetcher in workflow history (#1064) * Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix type error with query params Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: Autocomplete for bool values (#1072) Fix workflows query autocomplete to suggest the correct tokens for boolean values Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add feature flag for Failover History (#1070) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add failover history tab (#1071) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * chore: Added ts-node to dev-deps (#1074) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Hook to fetch & filter Failover History of a domain (#1075) Add hook for fetching and filtering failover history Add helper function to check if a ClusterFailover matches a given cluster attribute Add some types/constants for domain page failovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New Cron Tab (#1078) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Failover History table (#1076) * Add table to display failover history of a domain, with support for both active-passive and active-active domains Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Fix console.error pollution (#1077) * chore: Fix console.error pollution Signed-off-by: Tim Chan <tim.chan@uber.com> * Relocated to src/test-utils. Signed-off-by: Tim Chan <tim.chan@uber.com> --------- Signed-off-by: Tim Chan <tim.chan@uber.com> * Add flag for History Page v2 (#1081) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Filters for Failover History Table (#1079) Add filters for Failover History table, but only for active-active domains Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names Remove (now) unused styles file from DomainPageFailovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Create a grouping utility that only parses new events (#1065) * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * call onchange after updating pending events Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use sync processBatch for first page Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/helpers/workflow-history-grouper.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply PR comments * Update src/views/workflow-history/helpers/workflow-history-grouper.types.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Add modal to view full failover event (#1080) * Add modal for viewing an individual failover event, which is shown when "See more" in the table is clicked Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New components for Workflow History V2 (#1082) * Add new Workflow History V2 root component, which (for now) renders only a placeholder header component and placeholder tables. * Implement Workflow History Header with basic UI and sticky functionality * Add logic in WorkflowHistoryWrapper to render V2 UI based on feature flag Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * update test cases * hook for history grouper * remove comments * fetcher updates * add placeholder for fetcher * update fetcher mock * fetcher start update * update todo * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix copilot comments * remove extra comment * lint fix * change lastFlattented initial value to -1 * remove unused import * address comments --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Tim Chan <tim.chan@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> Co-authored-by: Tim Chan <timothyc@alum.mit.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan added 2 commits November 14, 2025 18:33

failover history table

ea6874d

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Add failover history filters

3bec929

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan force-pushed the failover-history-filters branch from b629f46 to 3bec929 Compare November 14, 2025 17:34

delete modal

fc48a81

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan marked this pull request as ready for review November 14, 2025 17:39

adhityamamallan requested a review from Copilot November 14, 2025 17:49

Copilot started reviewing on behalf of adhityamamallan November 14, 2025 17:50 View session

Copilot finished reviewing on behalf of adhityamamallan November 14, 2025 17:51

Copilot AI reviewed Nov 14, 2025

View reviewed changes

macrotim approved these changes Nov 15, 2025

View reviewed changes

...s/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx Outdated Show resolved Hide resolved

adhityamamallan added 3 commits November 17, 2025 14:32

Merge branch 'master' into failover-history-filters

ce9ad94

Use placeholder text instead of index

2b67689

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Merge branch 'master' into failover-history-filters

fc3f43c

adhityamamallan merged commit 1054087 into cadence-workflow:master Nov 17, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Filters for Failover History Table#1079

feat: Filters for Failover History Table#1079
adhityamamallan merged 6 commits intocadence-workflow:masterfrom
adhityamamallan:failover-history-filters

adhityamamallan commented Nov 14, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

macrotim commented Nov 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

adhityamamallan commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Unset

Suggestions

City ID

Primary cluster failovers only (cluster attribute value is greyed out)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

macrotim commented Nov 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adhityamamallan commented Nov 14, 2025 •

edited

Loading