refactor: Move types from workflow-history.types.ts to workflow-history-v2.types.ts#1177
Merged
adhityamamallan merged 6 commits intocadence-workflow:masterfrom Feb 19, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves workflow history type definitions from workflow-history.types.ts (v1) to workflow-history-v2.types.ts to prepare for upcoming changes to history event group computation. The refactoring maintains backward compatibility by keeping the v1 types intact while establishing an independent type system for v2.
Changes:
- Added comprehensive type definitions to
workflow-history-v2.types.ts, including event groups, history events, and filter configurations - Updated all imports in the
workflow-history-v2folder to reference the new local type definitions - Inlined
WorkflowEventStatusandWorkflowEventStatusBadgeSizetypes in v2 instead of importing from the badge component
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/views/workflow-history-v2/workflow-history-v2.types.ts |
Added 260+ lines of type definitions for workflow history v2, including all event group types, history event types, and related utilities |
src/views/workflow-history-v2/workflow-history-ungrouped-table/workflow-history-ungrouped-table.types.ts |
Updated import to reference local v2 types instead of v1 |
src/views/workflow-history-v2/workflow-history-ungrouped-table/helpers/__tests__/compare-ungrouped-events.test.ts |
Updated test import to use v2 types |
src/views/workflow-history-v2/workflow-history-ungrouped-event/__tests__/workflow-history-ungrouped-event.test.tsx |
Updated test import to use v2 types |
src/views/workflow-history-v2/workflow-history-timeline/workflow-history-timeline.types.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-timeline/helpers/get-timeline-row-from-event-group.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-timeline-event-group/workflow-history-timeline-event-group.types.ts |
Consolidated imports from v2 types |
src/views/workflow-history-v2/workflow-history-header/workflow-history-header.types.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.types.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx |
Updated test import to use v2 types |
src/views/workflow-history-v2/workflow-history-filters-menu/workflow-history-filters-menu.tsx |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.types.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-event-group/helpers/get-event-group-filtering-type.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/workflow-history-event-group/__tests__/workflow-history-event-group.test.tsx |
Updated test import to use v2 types |
src/views/workflow-history-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.types.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/hooks/use-group-details-entries.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/hooks/__tests__/use-group-details-entries.test.tsx |
Updated test import to use v2 types |
src/views/workflow-history-v2/helpers/get-navigation-bar-events-menu-items.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/helpers/generate-history-group-details.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts |
Updated test import to use v2 types |
src/views/workflow-history-v2/helpers/__tests__/generate-history-group-details.test.ts |
Updated test import to use v2 types |
src/views/workflow-history-v2/config/workflow-history-filters.config.ts |
Updated import to reference local v2 types |
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx |
Updated test import to use v2 types |
src/views/workflow-history-v2/__fixtures__/ungrouped-events-info.ts |
Updated import to reference local v2 types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adhityamamallan
changed the title
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
adhityamamallan
force-pushed
the
copy-types-from-v1
branch
from
f84cd3d to
cd00b87
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assem-Uber
approved these changes
Feb 19, 2026
Assem-Uber
pushed a commit
to Assem-Uber/cadence-web
that referenced
this pull request
Feb 20, 2026
…ry-v2.types.ts (cadence-workflow#1177) * Move Workflow History types from v1 folder to v2 folder, to prepare for changes to history event group computation * Refactor v2 code to use the types from workflow-history-v2.types.ts Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
added a commit
that referenced
this pull request
Feb 20, 2026
* fix decode params in cluster methods * fix url decode in worfklow actions APIs * refactor: Move history scroll handlers to dedicated hook (#1156) * Move code for Workflow History V2 scroll handlers (scroll to event, scroll up, scroll down) and variables (Virtuoso refs) to dedicated React hook * Fix a minor bug with scrollToEvent where it would not work with the first event Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * refactor: rename onClickEvent to onClickShowInTable in Workflow History Timeline (#1157) * To prepare for moving the click handling for events to a dedicated "Show in table" button, this PR renames the onClickEvent handler to onClickShowInTable Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Lift timeline state up to workflow history root (#1158) Lift timeline state up from WorkflowHistoryHeader to WorkflowHistoryV2, allowing sub-components in the list to open the timeline if necessary. Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * refactor: Use groupId from Event Groups entries instead of firstEventId in Workflow History Timeline (#1160) Instead of setting the row ID as the firstEventId for Workflow History Timeline rows, this PR passes the groupId (which, in practice, is the exact same thing) to the getTimelineRowFromEventGroup helper Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Show correct error banner message when failing to load domains from some clusters (#1162) Problem When the Cadence UI fails to connect to some clusters to load domains, we show an error banner with the list of problematic clusters. However, this banner currently lists all clusters instead of just the problematic ones. This is due to a mistake in the logic for evaluating problematic clusters. Solution Fix the logic for evaluating problematic clusters Break the getAllDomains helper up into separate helpers for better testability Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Add cron schedule descriptions to Workflow History V2 components (#1163) Add natural-language Cron descriptions (implemented in #1151) to Workflow History V2 details parsers config Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Use ClustersConfigs type in getAllDomains unit test (#1165) * Use server-side ClustersConfigs type and existing clusters configs fixtures in unit test for getAllDomains, to prevent getConfigValue's spy from assuming that it's of type PublicClustersConfigs (client-side) * Rename setup param to clustersConfigs from clusterConfigs, to match the type Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Add explicit "Copy link" text to history event link copy button (#1166) * Add explicit "Copy link" text to history event link copy button in accordance with existing designs, to make the button's intent clearer without needing to hover on it * Remove the "Copy link to event" tooltip that shows up when user initially hovers on the link button Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Add timeline scroll handler & target to useWorkflowHistoryScroll (#1167) * Add timeline Virtuoso ref, scroll handler and scroll target (event group) to useWorkflowHistoryScroll, to use for timeline <-> table integration Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Warning message when no workers are available for a task list (#1168) Signed-off-by: Yoav Levy <yoavlev2@gmail.com> * feat: Add "Show in Timeline" button to event groups in grouped Workflow History table (#1169) * Add timeline scroll handler in useWorkflowHistoryScroll hook with similar pattern to existing table scroll * Add "Show in timeline" button in event group details panel that scrolls to and highlights the group in the timeline * Implement animation effect for highlighted timeline rows using 2-second fade transition Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Add "Show in Table" button to event groups in Workflow History Timeline (#1171) * Add "Show in Table" button to event groups in Workflow History Timeline, to highlight event groups in the Workflow History tables * Remove the onClick functionality from the timeline event bar * Increase tooltip entry time to 600ms (and define it in a constant instead of hardcoding it) * Increase spacing between event tabs and action buttons from scale400 (12px) to scale1200 (48px) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Add "Show in Timeline" button to events in ungrouped Workflow History table (#1170) * Add the Show in Timeline button (added in #1169) to the ungrouped Workflow History table * Add groupId to UngroupedEventsInfo * Move createUngroupedEventsInfo test util to fixtures directory Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Improper wrapping & overflow on Workflow Summary page (#1174) * Rewrite the styles to use a simpler grid-based layout, distributing the space evenly between the summary details and the JSON panels * Allow the workflow title to overflow onto multiple lines Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Constrain size of group details tooltip in Workflow History timeline (#1176) * Constrain max width of the tooltip to 800px * Add an isScrollable prop to WorkflowHistoryEventDetails, constraining the height of non-panel details to 250px and making them scrollable if true * Pass this prop through from WorkflowHistoryTimelineEventGroup Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Dynamically resize history timeline for running workflows (#1172) * Add hook useCurrentTimeMs to accurately calculate the current time every second, instead of letting it be recalculated only on rerenders. * Add hook useSteppedDomainMaxMs to calculate the timeline's max domain based on events and current time Change the implementation of getTimelineMaxTimeMs to take current time as a parameter instead of calling Date.now() inside it * For running events without an end time (so, any running events besides timers), use current time as the bar's end point, so that bars smoothly expand * Add an outline to the timeline component * Move header padding to timeline container margin (still size400/16px) * Remove border between header cells Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: double decode params in cluster methods middleware (#1180) * fix decode params in cluster methods * fix double decoding * add search attribute api * fix: Stop click propagation when clicking on Workflow History summarized details (#1175) * Add new field hasClickableContent to details row item config, which is set if the item is meant to be clickable * Set this field to true for all existing links * Call e.stopPropagation() in the details entry onClick handler to prevent the click from propagating to parents, if hasClickableContent is true Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * refactor: Move types from workflow-history.types.ts to workflow-history-v2.types.ts (#1177) * Move Workflow History types from v1 folder to v2 folder, to prepare for changes to history event group computation * Refactor v2 code to use the types from workflow-history-v2.types.ts Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * fix: Double decode issue for summary page (#1183) * fix decode params in cluster methods * fix double decoding * fix double encoding for summary page * revert search attributes changes --------- Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Signed-off-by: Yoav Levy <yoavlev2@gmail.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Yoav Levy <yoavlev2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Builds + type checks + tests passing.