refactor: Change getCommonHistoryGroupFields to receive an object instead of individual params#1186
Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom Feb 23, 2026
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the getCommonHistoryGroupFields function to accept a single object parameter with named properties instead of 8 individual positional parameters. This improves code readability, especially for the 3 optional parameters that previously required passing undefined placeholders.
Changes:
- Updated
getCommonHistoryGroupFieldsfunction signature to use object destructuring with named parameters - Updated all 7 call sites across different history group generator functions to use the new object parameter syntax
- Updated the test file to use the new function signature
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
get-common-history-group-fields.ts |
Changed function signature from 8 positional parameters to object destructuring with named properties |
get-timer-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-single-event-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-signal-external-workflow-execution-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-request-cancel-external-workflow-execution-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-decision-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-child-workflow-execution-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-activity-group-from-events.ts |
Updated function call to use object syntax with named parameters |
get-common-history-group-fields.test.ts |
Updated test setup to use new object parameter syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assem-Uber
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change getCommonHistoryGroupFields (in workflow-history-v2) to receive an object instead of individual params, to improve readability of optional params.
Test plan
Builds & tests passing + ran locally to sanity-check.