feat: New history events group for Workflow Signaled events#1187
Merged
adhityamamallan merged 10 commits intocadence-workflow:masterfrom Feb 24, 2026
Merged
Conversation
f7d9e04 to
4565632
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated history event group for Workflow Signaled events in Workflow History V2 so they no longer appear as generic single “Event” groups, and so future filtering logic can treat them as a first-class group type.
Changes:
- Introduces
WorkflowSignaledas a newHistoryEventGroupTypeandHistoryEventsGroupvariant, plus a dedicatedWorkflowSignaledHistoryEventtype. - Updates the grouping pipeline to detect
workflowExecutionSignaledEventAttributesand build aWorkflowSignaledgroup with a label that includes the signal name. - Adjusts category filtering logic + fixtures/tests to reflect the new group type and mapping to the
SIGNALfilter category.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/views/workflow-history-v2/workflow-history-v2.types.ts |
Adds new group/event types for Workflow Signaled events and removes signaled from the single-event union. |
src/views/workflow-history-v2/helpers/workflow-history-grouper.ts |
Routes signaled events into the new WorkflowSignaled group builder. |
src/views/workflow-history-v2/helpers/get-history-group-from-events/get-workflow-signaled-group-from-events.ts |
New group builder that generates a signal-name-aware label and metadata mappings. |
src/views/workflow-history-v2/helpers/get-history-group-from-events/get-single-event-group-from-events.ts |
Removes Workflow Signaled handling from generic single-event labeling/status/summary. |
src/views/workflow-history-v2/helpers/check-history-event-group/is-workflow-signaled-event.ts |
New type guard for signaled events. |
src/views/workflow-history-v2/helpers/check-history-event-group/is-single-event.ts |
Removes signaled events from the “single event” classification. |
src/views/workflow-history-v2/config/workflow-history-event-group-category-filters.config.ts |
Updates SIGNAL/WORKFLOW categorization to rely on the new group type. |
src/views/workflow-history-v2/__fixtures__/workflow-history-workflow-signaled-events.ts |
Adds fixtures for Workflow Signaled events. |
src/views/workflow-history-v2/__fixtures__/workflow-history-single-events.ts |
Removes the signaled single-event fixture (now represented by the new fixture). |
src/views/workflow-history-v2/__fixtures__/workflow-history-event-groups.ts |
Adds a mock WorkflowSignaled group fixture used by tests. |
src/views/workflow-history-v2/.../__tests__/*.test.ts (multiple) |
Updates/introduces unit tests to validate the new group type, grouping, and filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
approved these changes
Feb 24, 2026
9686de8 to
5af3632
Compare
Assem-Uber
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new history events group for Workflow Signaled events, separating them from the other single history events.
Key differences:
Other changes:
Test plan
Added/updated unit tests + ran locally.
Before
After
With filters applied