Skip to content

feat: New history events group for Workflow Signaled events#1187

Merged
adhityamamallan merged 10 commits intocadence-workflow:masterfrom
adhityamamallan:workflow-signaled-group
Feb 24, 2026
Merged

feat: New history events group for Workflow Signaled events#1187
adhityamamallan merged 10 commits intocadence-workflow:masterfrom
adhityamamallan:workflow-signaled-group

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Feb 20, 2026

Summary

Add new history events group for Workflow Signaled events, separating them from the other single history events.

Key differences:

  • The signal name is now part of the event name itself
  • Dedicated group type

Other changes:

  • Add fixtures
  • Update filtering logic to account for new group type

Test plan

Added/updated unit tests + ran locally.

Before

Screenshot 2026-02-20 at 14 32 03

After

Screenshot 2026-02-20 at 14 32 57

With filters applied

Screenshot 2026-02-23 at 15 08 39

@adhityamamallan adhityamamallan changed the title feat: Workflow signaled group feat: New history events group for Workflow Signaled events Feb 20, 2026
@adhityamamallan adhityamamallan force-pushed the workflow-signaled-group branch 3 times, most recently from f7d9e04 to 4565632 Compare February 23, 2026 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated history event group for Workflow Signaled events in Workflow History V2 so they no longer appear as generic single “Event” groups, and so future filtering logic can treat them as a first-class group type.

Changes:

  • Introduces WorkflowSignaled as a new HistoryEventGroupType and HistoryEventsGroup variant, plus a dedicated WorkflowSignaledHistoryEvent type.
  • Updates the grouping pipeline to detect workflowExecutionSignaledEventAttributes and build a WorkflowSignaled group with a label that includes the signal name.
  • Adjusts category filtering logic + fixtures/tests to reflect the new group type and mapping to the SIGNAL filter category.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/views/workflow-history-v2/workflow-history-v2.types.ts Adds new group/event types for Workflow Signaled events and removes signaled from the single-event union.
src/views/workflow-history-v2/helpers/workflow-history-grouper.ts Routes signaled events into the new WorkflowSignaled group builder.
src/views/workflow-history-v2/helpers/get-history-group-from-events/get-workflow-signaled-group-from-events.ts New group builder that generates a signal-name-aware label and metadata mappings.
src/views/workflow-history-v2/helpers/get-history-group-from-events/get-single-event-group-from-events.ts Removes Workflow Signaled handling from generic single-event labeling/status/summary.
src/views/workflow-history-v2/helpers/check-history-event-group/is-workflow-signaled-event.ts New type guard for signaled events.
src/views/workflow-history-v2/helpers/check-history-event-group/is-single-event.ts Removes signaled events from the “single event” classification.
src/views/workflow-history-v2/config/workflow-history-event-group-category-filters.config.ts Updates SIGNAL/WORKFLOW categorization to rely on the new group type.
src/views/workflow-history-v2/__fixtures__/workflow-history-workflow-signaled-events.ts Adds fixtures for Workflow Signaled events.
src/views/workflow-history-v2/__fixtures__/workflow-history-single-events.ts Removes the signaled single-event fixture (now represented by the new fixture).
src/views/workflow-history-v2/__fixtures__/workflow-history-event-groups.ts Adds a mock WorkflowSignaled group fixture used by tests.
src/views/workflow-history-v2/.../__tests__/*.test.ts (multiple) Updates/introduces unit tests to validate the new group type, grouping, and filtering behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adhityamamallan adhityamamallan marked this pull request as ready for review February 24, 2026 11:46
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 4a5cac5 into cadence-workflow:master Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants