fix: Change highlighted fields for decision tasks#1195
Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom Feb 26, 2026
Merged
fix: Change highlighted fields for decision tasks#1195adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
b337b83 to
cee6d3e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the visibility of decision task failures and timeouts in the workflow history UI by adding field highlighting and adjusting which fields are displayed in event summaries.
Changes:
- Added
causefield to failed decision task events, and includedcausefield for timed out decision task events in both negative (red highlighting) and summary field configurations - Removed
startToCloseTimeoutSecondsfrom scheduled decision task event summaries to reduce visual clutter - Added comprehensive test coverage for the new field configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/views/workflow-history-v2/helpers/get-history-group-from-events/get-decision-group-from-events.ts | Updated field configuration to highlight failure/timeout fields and removed startToCloseTimeout from scheduled event display |
| src/views/workflow-history-v2/helpers/get-history-group-from-events/tests/get-decision-group-from-events.test.ts | Added tests for new timeout event field configuration and updated existing tests to reflect removed startToCloseTimeout field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../workflow-history-v2/helpers/get-history-group-from-events/get-decision-group-from-events.ts
Outdated
Show resolved
Hide resolved
.../workflow-history-v2/helpers/get-history-group-from-events/get-decision-group-from-events.ts
Outdated
Show resolved
Hide resolved
...ry-v2/helpers/get-history-group-from-events/__tests__/get-decision-group-from-events.test.ts
Outdated
Show resolved
Hide resolved
...ry-v2/helpers/get-history-group-from-events/__tests__/get-decision-group-from-events.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
dkrotx
approved these changes
Feb 26, 2026
3d96e30
into
cadence-workflow:master
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Decision task failures are not highlighted in the UI, and are easy to miss.
Solution
Test plan
Updated unit tests + ran locally.
Before
After
Timed out decision task