Skip to content

fix: Change highlighted fields for decision tasks#1195

Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan:decision-task-failures
Feb 26, 2026
Merged

fix: Change highlighted fields for decision tasks#1195
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan:decision-task-failures

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Feb 25, 2026

Summary

Problem

Decision task failures are not highlighted in the UI, and are easy to miss.

Solution

  • Add reason, failure details, and cause to the list of fields displayed in the event summary for failed/timed out decision tasks.
  • Highlight these fields as "negative" to apply red styling
  • Remove the startToClose timeout from decision tasks' event summary to reduce visual clutter (it comes from a default configuration anyway, and users should have no reason to change it)
  • Hide empty reason/cause fields in the event summary row

Test plan

Updated unit tests + ran locally.

Before

Screenshot 2026-02-25 at 16 15 47 Screenshot 2026-02-25 at 16 15 55

After

Screenshot 2026-02-25 at 11 48 27 Screenshot 2026-02-25 at 11 48 37

Timed out decision task

Screenshot 2026-02-25 at 17 02 54

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the visibility of decision task failures and timeouts in the workflow history UI by adding field highlighting and adjusting which fields are displayed in event summaries.

Changes:

  • Added cause field to failed decision task events, and included cause field for timed out decision task events in both negative (red highlighting) and summary field configurations
  • Removed startToCloseTimeoutSeconds from scheduled decision task event summaries to reduce visual clutter
  • Added comprehensive test coverage for the new field configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/views/workflow-history-v2/helpers/get-history-group-from-events/get-decision-group-from-events.ts Updated field configuration to highlight failure/timeout fields and removed startToCloseTimeout from scheduled event display
src/views/workflow-history-v2/helpers/get-history-group-from-events/tests/get-decision-group-from-events.test.ts Added tests for new timeout event field configuration and updated existing tests to reflect removed startToCloseTimeout field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 3d96e30 into cadence-workflow:master Feb 26, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants