fix: Allow all times to be selected in the Start Time filter when consecutive dates are picked#1196
Merged
adhityamamallan merged 5 commits intocadence-workflow:masterfrom Feb 26, 2026
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
gazi-yestemirova
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The date filter shows only 12:00 AM as a selectable option in the Start Time picker when consecutive dates are selected. This is because of a bug in the Baseweb TimePicker when
maxTimeis exactly 1 day afterminTime.minTime.dayEndvariable (midnight of the day afterstartTime's day) is set to the start of the next daymaxTimewe pass is strictly afterdayEnddayEnd=maxTime), it sets the TimePicker's max possible value to midnight ofstartTime's day, allowing for only one possible value - 12:00 AM.Solution
Only pass the
minTimeandmaxTimevalues if both fall on the same day.Test plan
Added unit tests to ensure the props are passed correctly + ran locally.
Before
Screen.Recording.2026-02-25.at.17.44.01.mov
After
Screen.Recording.2026-02-25.at.17.42.08.mov