feat: Add new, more prominent Workflow Status badges for history v2 view#1198
Merged
adhityamamallan merged 7 commits intocadence-workflow:masterfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new, more prominent status badge component for Workflow History V2 and wires it into the V2 ungrouped event view, grouped event headers, and the timeline.
Changes:
- Added
WorkflowHistoryEventStatusBadge(V2) implemented with BaseWebBadgeand aSkeletonloading state. - Introduced a centralized status→(icon, color, hierarchy) config for consistent rendering across V2.
- Updated V2 workflow history UI surfaces (ungrouped event, event group header, timeline) and adjusted unit tests/mocks accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/workflow-history-v2/workflow-history-ungrouped-event/workflow-history-ungrouped-event.tsx | Switches ungrouped event header status display to the new V2 badge and passes label as statusText. |
| src/views/workflow-history-v2/workflow-history-ungrouped-event/tests/workflow-history-ungrouped-event.test.tsx | Updates badge mock/typing to match new badge props (isLoading, statusText). |
| src/views/workflow-history-v2/workflow-history-timeline/workflow-history-timeline.tsx | Switches timeline rows to use the new V2 badge component. |
| src/views/workflow-history-v2/workflow-history-timeline/tests/workflow-history-timeline.test.tsx | Updates timeline badge mock to match new props. |
| src/views/workflow-history-v2/workflow-history-event-status-badge/workflow-history-event-status-badge.types.ts | Adds types for the new V2 badge config and component props. |
| src/views/workflow-history-v2/workflow-history-event-status-badge/workflow-history-event-status-badge.tsx | Implements the new V2 badge (Badge + Skeleton) using the shared config. |
| src/views/workflow-history-v2/workflow-history-event-status-badge/workflow-history-event-status-badge.styles.ts | Adds badge content layout styles and a styled spinner for ONGOING. |
| src/views/workflow-history-v2/workflow-history-event-status-badge/tests/workflow-history-event-status-badge.test.tsx | Adds unit tests validating loading behavior and per-status config rendering. |
| src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx | Uses the new V2 badge in group headers, wiring isLoading + latest metadata label as statusText. |
| src/views/workflow-history-v2/workflow-history-event-group/tests/workflow-history-event-group.test.tsx | Updates badge mock/typing and test descriptions for the new loading prop. |
| src/views/workflow-history-v2/config/workflow-history-event-status-badges.config.ts | Adds the status badge configuration mapping status → icon/hierarchy/color. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...kflow-history-v2/workflow-history-event-status-badge/workflow-history-event-status-badge.tsx
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-timeline/workflow-history-timeline.tsx
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
approved these changes
Feb 27, 2026
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Show resolved
Hide resolved
...2/workflow-history-event-status-badge/__tests__/workflow-history-event-status-badge.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I think the image showing |
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Member
Author
Correct; I updated the screenshot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Ran locally.
Previews of the new badges
Loading state
Screen.Recording.2026-02-27.at.14.19.02.mov
Started event
Screen.Recording.2026-02-27.at.14.21.38.mov
In the timeline chart
Screen.Recording.2026-02-27.at.14.22.21.mov