Add Help button to Domain Page#899
Merged
adhityamamallan merged 7 commits intocadence-workflow:masterfrom May 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Help button to the Domain Page with useful links, gated behind an Extended Domain Info feature flag, and also fixes a typo in the CLI commands modal.
- Fix typo in help text in the CLI commands modal.
- Integrate the DomainPageHelp component as an endEnhancer in DomainPageTabs.
- Introduce new components, types, and tests for the DomainPageHelp and its related elements.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/workflow-page/workflow-page-cli-commands-modal/workflow-page-cli-commands-modal.tsx | Fixed typo in the CLI commands description text. |
| src/views/domain-page/domain-page-tabs/domain-page-tabs.tsx | Added DomainPageHelp as the endEnhancer prop to display the Help button. |
| src/views/domain-page/domain-page-help/domain-page-help.tsx | Introduced the Help button component with a popover and feature flag gating. |
| src/views/domain-page/domain-page-help-item-button/* | Added/modified the Help item button components and types for handling link, modal, and action items. |
| src/views/domain-page/config/domain-page-help-menu.config.ts | Provided configuration for the Help menu with categories and items. |
| Various tests | Updated and added tests to ensure rendering and behavior conform with the new Help button functionality. |
Comments suppressed due to low confidence (1)
src/views/domain-page/domain-page-help/domain-page-help.tsx:14
- [nitpick] Consider renaming 'shouldEnableHelpTab' to a more descriptive name like 'isExtendedMetadataEnabled' to better reflect that this flag governs the extended metadata feature.
const { data: { metadata: shouldEnableHelpTab }, } = useSuspenseIsExtendedMetadataEnabled();
Assem-Uber
reviewed
May 14, 2025
src/views/domain-page/domain-page-help/domain-page-help.styles.ts
Outdated
Show resolved
Hide resolved
src/views/domain-page/domain-page-help/__tests__/domain-page-help.test.tsx
Show resolved
Hide resolved
...ews/domain-page/domain-page-help-item-button/__tests__/domain-page-help-item-button.test.tsx
Outdated
Show resolved
Hide resolved
955c9ff to
fef4271
Compare
Assem-Uber
approved these changes
May 15, 2025
Assem-Uber
pushed a commit
to Assem-Uber/cadence-web
that referenced
this pull request
May 16, 2025
- Add Help button to Domain Page, with useful links - Gate it behind the Extended Domain Info feature flag for now - Fix typo in CLI commands modal - Set default border radius for popovers to 12px
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.
On desktop:


On mobile (narrow screens):

