Skip to content

Add Help button to Domain Page#899

Merged
adhityamamallan merged 7 commits intocadence-workflow:masterfrom
adhityamamallan:help-button
May 15, 2025
Merged

Add Help button to Domain Page#899
adhityamamallan merged 7 commits intocadence-workflow:masterfrom
adhityamamallan:help-button

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented May 14, 2025

Summary

  • Add Help button to Domain Page, with useful links
  • Gate it behind the Extended Domain Info feature flag for now
  • Fix typo in CLI commands modal
  • Set default popover border radius to 12px

Test plan

Unit tests + ran locally.

On desktop:
Screenshot 2025-05-14 at 11 05 34 AM
Screenshot 2025-05-14 at 11 05 41 AM

On mobile (narrow screens):
Screenshot 2025-05-14 at 11 06 27 AM
Screenshot 2025-05-14 at 11 06 31 AM

@adhityamamallan adhityamamallan marked this pull request as ready for review May 14, 2025 09:10
@adhityamamallan adhityamamallan requested a review from Copilot May 14, 2025 09:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Help button to the Domain Page with useful links, gated behind an Extended Domain Info feature flag, and also fixes a typo in the CLI commands modal.

  • Fix typo in help text in the CLI commands modal.
  • Integrate the DomainPageHelp component as an endEnhancer in DomainPageTabs.
  • Introduce new components, types, and tests for the DomainPageHelp and its related elements.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/views/workflow-page/workflow-page-cli-commands-modal/workflow-page-cli-commands-modal.tsx Fixed typo in the CLI commands description text.
src/views/domain-page/domain-page-tabs/domain-page-tabs.tsx Added DomainPageHelp as the endEnhancer prop to display the Help button.
src/views/domain-page/domain-page-help/domain-page-help.tsx Introduced the Help button component with a popover and feature flag gating.
src/views/domain-page/domain-page-help-item-button/* Added/modified the Help item button components and types for handling link, modal, and action items.
src/views/domain-page/config/domain-page-help-menu.config.ts Provided configuration for the Help menu with categories and items.
Various tests Updated and added tests to ensure rendering and behavior conform with the new Help button functionality.
Comments suppressed due to low confidence (1)

src/views/domain-page/domain-page-help/domain-page-help.tsx:14

  • [nitpick] Consider renaming 'shouldEnableHelpTab' to a more descriptive name like 'isExtendedMetadataEnabled' to better reflect that this flag governs the extended metadata feature.
const { data: { metadata: shouldEnableHelpTab }, } = useSuspenseIsExtendedMetadataEnabled();

@adhityamamallan adhityamamallan merged commit bc3821e into cadence-workflow:master May 15, 2025
1 check passed
@adhityamamallan adhityamamallan deleted the help-button branch May 15, 2025 12:19
Assem-Uber pushed a commit to Assem-Uber/cadence-web that referenced this pull request May 16, 2025
- Add Help button to Domain Page, with useful links
- Gate it behind the Extended Domain Info feature flag for now
- Fix typo in CLI commands modal
- Set default border radius for popovers to 12px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants