Add ungrouped event table to Workflow History page#926
Merged
adhityamamallan merged 16 commits intocadence-workflow:masterfrom Jun 23, 2025
Merged
Add ungrouped event table to Workflow History page#926adhityamamallan merged 16 commits intocadence-workflow:masterfrom
adhityamamallan merged 16 commits intocadence-workflow:masterfrom
Conversation
adhityamamallan
force-pushed
the
ungrouped-view
branch
from
21de9e3 to
3c08849
Compare
adhityamamallan
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a toggleable ungrouped event timeline to the Workflow History page and covers it with unit tests.
- Registers a new
ungroupedHistoryViewEnabledquery parameter and persists it in URL. - Implements an ungrouped events table (sorting, infinite loading, and scrolling) alongside existing grouped timeline.
- Introduces related components (
WorkflowHistoryUngroupedTable,WorkflowHistoryUngroupedEvent), helpers, styles, and tests.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/workflow-page/config/workflow-page-query-params.config.ts | Registers ungroupedHistoryViewEnabled query param |
| src/views/workflow-history/workflow-history.types.ts | Extends VisibleHistoryGroupRanges with ungrouped index fields |
| src/views/workflow-history/workflow-history.tsx | Adds toggle, ungrouped events logic, scrolling, and load‐more hooks |
| src/views/workflow-history/workflow-history.styles.ts | Styles for ungrouped container and rename of toggle override key |
| src/views/workflow-history/workflow-history-ungrouped-table/* | New ungrouped table component, types, styles, and tests |
| src/views/workflow-history/workflow-history-ungrouped-event/* | New ungrouped event component, types, styles, helpers, and tests |
| src/views/workflow-history/helpers/compare-ungrouped-events.ts | Comparator for sorting ungrouped events and its unit tests |
| src/views/workflow-history/config/workflow-history-page-size.config.ts | New page size constant for history pagination |
| src/views/workflow-history/config/workflow-history-ungrouped-grid-template-columns.config.ts | Defines grid template for ungrouped table columns |
| return ( | ||
| <> | ||
| <styled.TableHeader> | ||
| <div>ID</div> |
There was a problem hiding this comment.
The grid template defines six columns (including a badge column) but the header only renders five <div> cells. Add a placeholder header cell for the retries/badge column or adjust the grid template to match.
Contributor
There was a problem hiding this comment.
We are not wrapping the header text so adding it wont fix the alignment
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adhityamamallan
changed the title
Assem-Uber
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Added/updated unit tests + ran locally.
Screen.Recording.2025-06-20.at.5.14.55.PM.mov