Enhance Query Input with Autocomplete#930
Merged
adhityamamallan merged 22 commits intocadence-workflow:masterfrom Jun 30, 2025
Merged
Enhance Query Input with Autocomplete#930adhityamamallan merged 22 commits intocadence-workflow:masterfrom
adhityamamallan merged 22 commits intocadence-workflow:masterfrom
Conversation
timl3136
reviewed
Jun 24, 2025
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
timl3136
approved these changes
Jun 24, 2025
Merge remote-tracking branch 'origin/autocomplete_feature' into autocomplete_feature
timl3136
reviewed
Jun 24, 2025
timl3136
reviewed
Jun 24, 2025
timl3136
reviewed
Jun 24, 2025
timl3136
reviewed
Jun 24, 2025
adhityamamallan
requested changes
Jun 25, 2025
Member
adhityamamallan
left a comment
There was a problem hiding this comment.
Hey, I had some comments regarding the code; but could you also share some screenshots of this new input?
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the query input component by adding autocomplete suggestions to help users build queries faster and with fewer errors.
- Integrates react-autosuggest into the query input component.
- Adds a new autocompletes module with preset suggestions for attributes, operators, and statuses.
- Updates tests and package dependencies to support the new autocomplete functionality.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx | Integrated react-autosuggest, added suggestion fetching/selection, and updated input rendering logic. |
| src/views/shared/workflows-header/workflows-query-input/autocompletes.tsx | Introduced a new module that defines autocomplete suggestions. |
| src/views/shared/workflows-header/workflows-query-input/tests/workflows-query-input.test.tsx | Adjusted tests to account for the new behavior (with some tests skipped due to jsdom limitations). |
| package.json | Added react-autosuggest dependency and its TypeScript definitions. |
Comments suppressed due to low confidence (2)
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx:294
- The onSubmit function is referenced in the form submission handler but is not defined or passed as a prop. Consider either adding onSubmit to the component's props or using an existing prop like refetchQuery if that was the intended behavior.
onSubmit();
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx:250
- [nitpick] The conversion and deletion of 'max', 'min', and 'step' properties is performed twice in renderInputComponent. Consolidating this logic could improve maintainability.
});
adhityamamallan
requested changes
Jun 25, 2025
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/autocompletes.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/autocompletes.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/.autocompletes.ts
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/.autocompletes.ts
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/.autocompletes.ts
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/.autocompletes.ts
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/helpers/get-autocomplete-suggestions.ts
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.types.ts
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-header/workflows-query-input/workflows-query-input.tsx
Outdated
Show resolved
Hide resolved
...views/shared/workflows-header/workflows-query-input/__tests__/workflows-query-input.test.tsx
Outdated
Show resolved
Hide resolved
adhityamamallan
approved these changes
Jun 27, 2025
...ed/workflows-header/workflows-query-input/helpers/tests/get-autocomplete-suggestions.test.ts
Show resolved
Hide resolved
adhityamamallan
added a commit
to adhityamamallan/cadence-web
that referenced
this pull request
Jun 30, 2025
This reverts commit d373034.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Autocomplete feature to Query Input. Query bar provides helpful suggestions as you type and guides in building queries without needing to memorize specific attribute names. Leads to fewer errors and makes the process of filtering workflows quicker and efficient. Performed local testing using development environment, ensuring styling of component was maintained.