Add react-query wrapper hook for fetching Workflow Diagnostics#947
Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom Jul 17, 2025
Merged
Conversation
adhityamamallan
force-pushed
the
diagnostics-hook
branch
from
ae81b68 to
3f308bb
Compare
Assem-Uber
reviewed
Jul 17, 2025
|
|
||
| export default function useDiagnoseWorkflow(params: UseDiagnoseWorkflowParams) { | ||
| /** | ||
| * We intentionally use a regular (non-suspense) query for diagnostics because: |
Contributor
There was a problem hiding this comment.
Our default now is going with (non-suspense) queries unless there is a benifit from rendering the result on the server.
The above line makes it seem the opposite.
Assem-Uber
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add react-query hook
useDiagnoseWorkflowfor fetching Workflow Diagnostics, which makes a call to thediagnoseWorkflowroute handler.Test plan
Tested in follow-up: #948