Shard Controller life-cycle bug fix#1
Merged
tamer-eldeeb merged 2 commits intocadence-workflow:masterfrom Feb 22, 2017
samarabbas:shard-controller-lifecycle-fix
Merged
Shard Controller life-cycle bug fix#1tamer-eldeeb merged 2 commits intocadence-workflow:masterfrom samarabbas:shard-controller-lifecycle-fix
tamer-eldeeb merged 2 commits intocadence-workflow:masterfrom
samarabbas:shard-controller-lifecycle-fix
Conversation
We were not setting the shardID on shardContext when the shard is acquired by a host. This caused the shardID to be intialized to 0 for all shards. We used the same shardID for sending the closed event on the shardClosedCh which caused us to always remove the shardID 0. Updated onebox setup to have support for spinning up multiple history hosts. Also changed the integration tests to use 2 history hosts for running the tests. Also made some minor logging fixes.
Remove redundant tag to add hostname on service startup. Change the number of history hosts to 1 due to data race issue.
wxing1292
pushed a commit
that referenced
this pull request
Sep 18, 2019
c-warren
added a commit
that referenced
this pull request
Sep 30, 2025
<!-- Tell your future self why have you made these changes --> **Why?** Our existing commit process: - doesn't immediately convey when there are breaking changes to the releaser - doesn't provide information about how to categorize changes in each release - is entirely manual preparing releases - doesn't always give "good" information about what is contained within a commit - doesn't give a good idea of the risk of a given commit Furthermore, users have stated that our release notes do not provide easily discernable information about what is in a release, including: - if there are breaking changes - which features are in a given release - why they should upgrade Adding conventional commits aims to tackle these pieces and make contributing to the repository significantly easier. This PR adds a linter that will give feedback to developers on their commit message style, and will eventually enforce conventional commits for each merge PR. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Currently testing. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Adding this GitHub action may have unintended consequences for the commit process, and should be monitored to ensure that it doesn't inhibit merging to the repository. <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** N/A <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes**⚠️ TODO
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not setting the shardID on shardContext when the shard is
acquired by a host. This caused the shardID to be intialized to 0 for
all shards. We used the same shardID for sending the closed event on
the shardClosedCh which caused us to always remove the shardID 0.
Updated onebox setup to have support for spinning up multiple history
hosts. Also changed the integration tests to use 2 history hosts for
running the tests.
Also made some minor logging fixes.