fix(active-active): Fix query workflow for active-active domains#7339
Merged
Shaddoll merged 1 commit intocadence-workflow:masterfrom Oct 16, 2025
Merged
fix(active-active): Fix query workflow for active-active domains#7339Shaddoll merged 1 commit intocadence-workflow:masterfrom
Shaddoll merged 1 commit intocadence-workflow:masterfrom
Conversation
Shaddoll
requested review from
3vilhamster,
Groxx,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
c-warren
reviewed
Oct 16, 2025
| clusterAttribute := mutableState.GetExecutionInfo().ActiveClusterSelectionPolicy.GetClusterAttribute() | ||
| activeClusterInfo, exists := de.GetActiveClusterInfoByClusterAttribute(clusterAttribute) | ||
| if !exists { | ||
| // TODO: this is only possible if the domain metadata doesn't have the cluster attribute, should we return an error instead? |
Contributor
There was a problem hiding this comment.
I think we want to default to the domains ActiveClusterName here - this will be a 'normal' scenario when someone uses a ClusterAttribute that exists but hasn't been onboarded to their domain data yet.
c-warren
approved these changes
Oct 16, 2025
instamitch
pushed a commit
to instamitch/cadence
that referenced
this pull request
Oct 21, 2025
…ence-workflow#7339) <!-- Describe what has changed in this PR --> **What changed?** Fix query workflow for active-active domains <!-- Tell your future self why have you made these changes --> **Why?** In active-active domains, the active cluster of an workflow is also determined by the active cluster selection policy. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unit tests <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** Signed-off-by: Mitch O'Dea <mitchelo@netapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fix query workflow for active-active domains
Why?
In active-active domains, the active cluster of an workflow is also determined by the active cluster selection policy.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes