fix(active-active): Fix start workflow with terminate if running policy for active-active domains#7361
Merged
Shaddoll merged 3 commits intocadence-workflow:masterfrom Oct 22, 2025
Merged
Conversation
…cy for active-active domains
Shaddoll
requested review from
3vilhamster,
Groxx,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
c-warren
approved these changes
Oct 21, 2025
...ication/testdata/replication_simulation_activeactive_signalwithstart_terminateifrunning.yaml
Show resolved
Hide resolved
| } | ||
| // TODO(active-active): This is a short-term fix to handle this special case, because we don't have a way to terminate the existing workflow in a different cluster and start a new workflow in the current cluster | ||
| // atomically in one transaction. We'll review this when we have time to implement a better solution. | ||
| return nil, &types.BadRequestError{Message: "Cannot terminate the existing workflow and start a new workflow because it is active in a different cluster with a different active cluster selection policy."} |
Contributor
There was a problem hiding this comment.
Are we able to add unit tests for this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Update StartWorkflow and SignalWithStartWorkflow API to return a bad request error, if the current workflow is active in a different cluster with a different active cluster policy and the workflowID reuse policy is terminate if running.
Why?
We don't support cross-region transactions, so we're unable to terminate a workflow that's active in another cluster and start a new workflow in the current cluster.
How did you test it?
simulation tests
Potential risks
Release notes
Documentation Changes