feat(shard-distributor): integrate executor cleanup with shard assignment#7440
Merged
jakobht merged 7 commits intocadence-workflow:masterfrom Nov 18, 2025
Merged
feat(shard-distributor): integrate executor cleanup with shard assignment#7440jakobht merged 7 commits intocadence-workflow:masterfrom
jakobht merged 7 commits intocadence-workflow:masterfrom
Conversation
…ures shards are not ownerless Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
jakobht
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
eleonoradgr
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Integrated executor cleanup into the shard assignment loop to ensure all shards always have an owner. Executor deletion now happens atomically with shard reassignment in a single ETCD transaction.
Why?
Previously, the cleanup loop would delete stale executors separately from shard assignment, creating a window where shards could be left without an owner. This integration ensures atomic deletion and reassignment.
How did you test it?
Potential risks
Low - changes are localized to the experimental shard distributor service with proper transactional guards.
Release notes
N/A - experimental feature only
Documentation Changes
None