fix(shard-distributor): prevent context cancellation in streaming WatchNamespaceState RPC#7474
Merged
jakobht merged 1 commit intocadence-workflow:masterfrom Nov 24, 2025
Merged
Conversation
The timeout wrapper was immediately cancelling the context for streaming RPCs, causing the stream to fail with "context canceled" errors. For streaming RPCs, the context must remain alive for the stream's entire lifetime, not just the initial call. Changes: - Add sharddistributorClient.WatchNamespaceState to noTimeoutAPIs list - Regenerate timeout wrapper without defer cancel() for this method Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
jakobht
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
arzonus
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
sharddistributorClient.WatchNamespaceStateto thenoTimeoutAPIslist in the timeout wrapper template and regenerated the wrapper code.Why?
The timeout wrapper was immediately cancelling the context for streaming RPCs, causing
WatchNamespaceStatestreams to fail with "context canceled" errors. For streaming RPCs, the context must remain alive for the stream's entire lifetime, not just the initial call.How did you test it?
Verified locally that WatchNamespaceState streams now remain open without premature cancellation.
Potential risks
Low risk. This only affects the WatchNamespaceState streaming RPC, allowing it to stay open as intended rather than being cancelled immediately.
Release notes
Documentation Changes
None