fix(shard-manager): fixed the ETCD integration test#7502
Merged
jakobht merged 4 commits intocadence-workflow:masterfrom Dec 1, 2025
Merged
fix(shard-manager): fixed the ETCD integration test#7502jakobht merged 4 commits intocadence-workflow:masterfrom
jakobht merged 4 commits intocadence-workflow:masterfrom
Conversation
…fixing the makefile so it does Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
jakobht
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
dkrotx
approved these changes
Dec 1, 2025
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
Signed-off-by: Jakob Haahr Taankvist <jht@uber.com>
eleonoradgr
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added an additional pattern to look for when checking if a package has ETCD integration tests
Why?
A helper setting up the tests was matching the pattern, not the packages that needed testing.
How did you test it?
Tested locally that now unit tests fails if we break them
Potential risks
Release notes
Documentation Changes